West Midlands | July-SDC | Gabriel Deng |Sprint 4 | Laptop-allocation#38
West Midlands | July-SDC | Gabriel Deng |Sprint 4 | Laptop-allocation#38gai93003 wants to merge 2 commits into
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
4 similar comments
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
gai93003
added
🏕 Priority Mandatory
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
gai93003
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This is a good start at this task, and it will work for the interactive method you're using. But if you re-read the spec in the task (https://sdc.codeyourfuture.io/decomposition/sprints/4/backlog/#04-implement-laptop-allocation) It's asking for a specific method that takes a list of possible laptops, a list of possible people, and then returns a matching for all of them.
Can you extend your code to meet that criteria?
LonMcGregor
added
Reviewed
|
Hey @LonMcGregor, thanks for clearing that up for me. I will try to adapt
my current implementation to meet that criteria.
…On Tue, 28 Oct 2025 at 15:15, LonMcGregor ***@***.***> wrote:
***@***.**** commented on this pull request.
This is a good start at this task, and it will work for the interactive
method you're using. But if you re-read the spec in the task (
https://sdc.codeyourfuture.io/decomposition/sprints/4/backlog/#04-implement-laptop-allocation)
It's asking for a specific method that takes a list of possible laptops, a
list of possible people, and then returns a matching for all of them.
Can you extend your code to meet that criteria?
—
Reply to this email directly, view it on GitHub
<#38 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC3JQE6W22B2EQAS5FAYLOD3Z6B7RAVCNFSM6AAAAACJVO2WI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOBZGMYDENBQGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
|
Hi @LonMcGregor, The link is no longer functional. I think the sprint is no longer not existing and as such amd getting 'Page not found'. What do you suggest I should do? |
|
The task has been moved here: https://sdc.codeyourfuture.io/tools/sprints/5/backlog/#implement-laptop-allocation Specifically,have a look at the part which says "Write a function with this signature:" Your solution works for a single person, given by the input. How would you allocate multiple laptops to multiple people? |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Could you add some examples at the end of the script so I can see how you are testing this function please?
This looks like an interesting implementation, can you explain how you are using masks here?
2 participants
Learners, PR Template
Self checklist